discuss: potential direction for refactoring differential tests #1293
Conversation
|
This does seem much cleaner to me! |
Update on my side: not sure |
|
Hey hey, just an update here @anna-carroll / @0age : we're aware of the issues with |
This is amazing @Evalir I think I've been able to verify that the fix works reliably! I've started in on deprecating the stateless modifier in favor of using snapshots. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 99.77% 99.70% -0.08%
==========================================
Files 22 22
Lines 1361 1363 +2
Branches 220 220
==========================================
+ Hits 1358 1359 +1
- Misses 3 4 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Motivation
In conversations with @jameswenzel , he said that Foundry had fixed the issue discussed here #809 - that rolling back chain state using vm.snapshot no longer erases failed test assertions.
If this is true, the
statelessmodifier is no longer necessary, and it is possible to refactor Differential tests to use a simpler setup.Solution
Here I've put forth a potential direction for refactoring Differential tests. I can extend to other tests currently using
statelessif we align on the approach.